impl(oauth2): add AllowedLocations methods to minimal iam rest stub#16067
impl(oauth2): add AllowedLocations methods to minimal iam rest stub#16067scotthart merged 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the AllowedLocations functionality within the IAM Credentials REST client, supporting service accounts, workload identities, and workforce identities. It also introduces a ValidateStringArrayField utility for JSON parsing. The review feedback identifies that the AllowedLocations endpoint should use the GET method instead of POST, necessitating the removal of the request payload and updates to mock expectations in tests. Additionally, a copy-paste error was found in the unit tests for the new JSON parsing utility.
google/cloud/internal/oauth2_minimal_iam_credentials_rest_test.cc
Outdated
Show resolved
Hide resolved
google/cloud/internal/oauth2_minimal_iam_credentials_rest_test.cc
Outdated
Show resolved
Hide resolved
google/cloud/internal/oauth2_minimal_iam_credentials_rest_test.cc
Outdated
Show resolved
Hide resolved
google/cloud/internal/oauth2_minimal_iam_credentials_rest_test.cc
Outdated
Show resolved
Hide resolved
scotthart
force-pushed
the
rab_minimal_iam_2
branch
from
94105f6 to
3078eef
Compare
scotthart
force-pushed
the
rab_minimal_iam_2
branch
from
3078eef to
24b116f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16067 +/- ##
==========================================
- Coverage 92.69% 92.68% -0.01%
==========================================
Files 2343 2343
Lines 216674 216959 +285
==========================================
+ Hits 200852 201097 +245
- Misses 15822 15862 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Adds methods to get the allowed locations from the IAM credentials REST endpoint.